Skip to content

Fix mypy errors for pandas\tests\*: test_convert_to.py #28965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix mypy errors for pandas\tests\*: test_convert_to.py #28965

merged 1 commit into from
Oct 18, 2019

Conversation

lrm25
Copy link
Contributor

@lrm25 lrm25 commented Oct 14, 2019

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Oct 14, 2019
@lrm25 lrm25 closed this Oct 16, 2019
@lrm25 lrm25 reopened this Oct 16, 2019
@jreback
Copy link
Contributor

jreback commented Oct 18, 2019

btw @WillAyd @simonjayhawkins feel free to merge mypy fixes when you guys are satisfied (generally)

@WillAyd WillAyd added this to the 1.0 milestone Oct 18, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this lgtm @simonjayhawkins

@simonjayhawkins simonjayhawkins merged commit 45dc6d3 into pandas-dev:master Oct 18, 2019
@simonjayhawkins
Copy link
Member

Thanks @lrm25

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants