TST: added test for df.loc modify datetime columns #28964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mroeschke @simonjayhawkins |
mroeschke
reviewed
Oct 14, 2019
|
Hello @rohitsanj! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-29 04:56:10 UTC |
|
@mroeschke Hey, I realised I hadn't written the test case properly. I've updated it now. Can you check it out? |
jreback
added
Indexing
jreback
requested changes
Oct 15, 2019
jreback
requested changes
Oct 16, 2019
|
Thanks for the commit @gfyoung |
|
Thanks @rohitsanj, @gfyoung! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
* TST: added test for df.loc modifies datetime columns Issue number pandas-dev#28837 * ran black pandas command * MAINT: Address reviewer comments
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* TST: added test for df.loc modifies datetime columns Issue number pandas-dev#28837 * ran black pandas command * MAINT: Address reviewer comments
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* TST: added test for df.loc modifies datetime columns Issue number pandas-dev#28837 * ran black pandas command * MAINT: Address reviewer comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant GitHub issue #28837
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff