CLN: move small bits outside of try/excepts #28962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Oct 14, 2019
WillAyd
reviewed
Oct 14, 2019
| @@ -292,12 +292,10 @@ def _try_aggregate_string_function(self, arg, *args, **kwargs): | |||
|
|
|||
| f = getattr(np, arg, None) | |||
| if f is not None: | |||
| try: | |||
| if hasattr(self, "__array__"): | |||
There was a problem hiding this comment.
Do we need to account for __array_ufunc__ or __array_function__ here as well? @TomAugspurger might want to take a look
There was a problem hiding this comment.
IIUC, this change is OK since we're checking if self has __array__, which our Index / Series objects have (in addition to array_ufunc)
| @@ -598,14 +598,7 @@ def pipe(self, func, *args, **kwargs): | |||
| plot = property(GroupByPlot) | |||
|
|
|||
| def _make_wrapper(self, name): | |||
| if name not in self._apply_whitelist: | |||
There was a problem hiding this comment.
Nice cleanup. At a glance this looks like a pretty interesting factory...
There was a problem hiding this comment.
Yah, this used to be called from within __gettattr__ (and exec was involved) Recently changed to be called from properties generated directly from apply_whitelist, so this check is no longer necessary
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.