REF: re-raise AssertionError unchanged #28959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Oct 14, 2019
| @@ -251,6 +251,8 @@ def aggregate(self, func=None, *args, **kwargs): | |||
|
|
|||
| try: | |||
| return self._python_agg_general(func, *args, **kwargs) | |||
| except AssertionError: | |||
There was a problem hiding this comment.
Hmm what's the point of the bare raise here? I get needed to differentiate now from the except Exception, but coupled with change above is there something actually throwing the AssertionError? Or do we mean to be catching ValueError here?
There was a problem hiding this comment.
but coupled with change above is there something actually throwing the AssertionError
No, which means that during development we can now add assertions and not have them get swallowed.
|
lgtm. pls rebase |
|
rebased+green |
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be all the remaining places where we catch
Exceptionin groupby/apply/resample code. This should make debugging much easier going forward.cc @jreback @WillAyd