Skip to content

TST: add test_series_any_timedelta for GH17667 #28942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2019
Merged

TST: add test_series_any_timedelta for GH17667 #28942

merged 2 commits into from
Oct 13, 2019

Conversation

rohitsanj
Copy link
Contributor

@rohitsanj rohitsanj commented Oct 12, 2019

Test case example is the same as the one given in the issue #17667

the dataframe used to test is same as the one mentioned in issue
GH17667
@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Oct 12, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitsanj thanks for the PR. couple of suggestions.

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Oct 13, 2019
@simonjayhawkins simonjayhawkins merged commit 0eee324 into pandas-dev:master Oct 13, 2019
@simonjayhawkins
Copy link
Member

Thanks @rohitsanj

@mroeschke
Copy link
Member

@rohitsanj feel free to contribute more tests like this! https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+label%3A%22Needs+Tests%22

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@rohitsanj rohitsanj deleted the timedelta-any-test branch October 24, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.any(axis={0, 1}) returns inconsistent values for non-zero timedelta
3 participants