TST: Fix 36 maybe_promote xfails wanting np.bytes_ instead of np.object_ #28861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should never have bytes as these are not a pandas supported dtype; anything that is not a standard (str, int, float, m8, M8 etc, or EA dtype) would just promote to object bytes are not special in that regard |
agreed, that matches what this PR does. The xfailed tests that this fixes do not match what you said |
WillAyd
approved these changes
Oct 10, 2019
jreback
reviewed
Oct 11, 2019
| else: | ||
| pytest.xfail("wrong missing value marker") | ||
| else: | ||
| if not issubclass(dtype.type, np.bytes_): |
There was a problem hiding this comment.
could enhance / make new test that uses an object here (e.g. list / tuple), IOW something that is treated similarly but is not also a numpy dtype. (future PR)
|
thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jreback less trivial than some of the others. These changes are based on my understanding that maybe_promote should never be returning np.bytes_ dtype; those cases all become np.object_. That is what maybe_promote currently does, and this updates the tests to expect that behavior.