ENH: Add optional argument keep_index to dataframe melt method (merged master onto old PR) #28859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the decrease in code coverage, I assume tests will need to be added here: I'm unfamiliar with how the tests are actually structured, so if someone could provide some direction, I could put together a test for review. |
|
Yep tests are pretty much the most important part of any PR. If you can add someone can take a look |
|
@smsaladi this needs tests for the new behavior |
|
Closing as I think this is stale, but @smsaladi feel free to ping if you want to pick back up and address comments |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges master onto @NiklasKeck's PR branch (#17440) to add an optional argument to keep_index to
pd.melt. There is quite a bit of discussion between the following 2 PRs and issues:Index gets lost when DataFrame melt method is used #17440
ENH: Add optional argument keep_index to dataframe melt method #17459
Melt enhance #17677
Please let me know if additional things need to be done to complete this PR
Setting keep_index to True will reuse the original DataFrame index +
names of melted columns as additional level. closes issue #17440
(cherry picked from commit 0c64bf0)
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff