Skip to content

TST: Update test in #28798 to use a Categorical #28824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

topper-123
Copy link
Contributor

I merged #28798 too fast, as the column "Name" wasn't a Categorical, which was to be tested. I've made it a Categorical and for good measure I've added ordered_fixture to the test.

@topper-123 topper-123 added Categorical Categorical Data Type Groupby Testing pandas testing functions or related to the test suite labels Oct 7, 2019
@topper-123
Copy link
Contributor Author

topper-123 commented Oct 7, 2019

I get this error, which doesn't seem to be related to my PR:

pytest -m "single and not slow and not network" -n 1 -s --strict --durations=10 --junitxml=test-data-single.xml pandas
Traceback (most recent call last):
  File "/home/vsts/miniconda3/envs/pandas-dev/bin/pytest", line 11, in <module>
    sys.exit(main())
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/config/__init__.py", line 58, in main
    config = _prepareconfig(args, plugins)
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/config/__init__.py", line 182, in _prepareconfig
    config = get_config()
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/config/__init__.py", line 153, in get_config
    pluginmanager.import_plugin(spec)
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/config/__init__.py", line 522, in import_plugin
    __import__(importspec)
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/tmpdir.py", line 25, in <module>
    class TempPathFactory(object):
  File "/home/vsts/miniconda3/envs/pandas-dev/lib/python3.6/site-packages/_pytest/tmpdir.py", line 35, in TempPathFactory
    lambda p: Path(os.path.abspath(six.text_type(p)))
TypeError: attrib() got an unexpected keyword argument 'convert'
##[error]Bash exited with code '1'.

This doesn't seem to be related to this PR.

@topper-123 topper-123 merged commit bee17d5 into pandas-dev:master Oct 8, 2019
@topper-123 topper-123 deleted the update_test_groupby_cat_preserves_structure branch October 8, 2019 06:23
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant