Skip to content

TST: Added SA01, SA02, and SA03 error checks to the Travis CI Build #28789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChiefMilesEdgeworth
Copy link
Contributor

These error types no longer show errors on master, so they're ready to be turned on for builds.

These error types no longer show errors on master, so they're ready to be turned on for builds.
@ChiefMilesEdgeworth ChiefMilesEdgeworth marked this pull request as ready for review October 4, 2019 15:36
@WillAyd WillAyd added the Docs label Oct 4, 2019
@WillAyd WillAyd added this to the 1.0 milestone Oct 4, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 4, 2019

lgtm. This doesn't fully close the issue referenced though right? Would SA01 and SA04 still not be required to fully close?

@ChiefMilesEdgeworth
Copy link
Contributor Author

Those weren't part of the errors being run in that issue. If you'd like I can look into if those are passing to, and if not edit the PR so it addresses the issue instead of closing it.

@WillAyd
Copy link
Member

WillAyd commented Oct 4, 2019

Yea I guess if you can check on those would be great - they are all part of the "See Also" validation so I think would make sense to include if not a lot of effort

@ChiefMilesEdgeworth
Copy link
Contributor Author

Looks like SA01 is clean too, but SA04 has a lot of issues. I'll add SA01 to the checks run for now. We should open a new issue for just SA04, so people can focus down on just that error.

SA01 is also error-free right now, so I'm adding it as well.
@ChiefMilesEdgeworth ChiefMilesEdgeworth changed the title TST: Added SA02,SA03 error checks to the Travis CI Build TST: Added SA01, SA02, and SA03 error checks to the Travis CI Build Oct 4, 2019
@WillAyd
Copy link
Member

WillAyd commented Oct 4, 2019

Sounds good to me - if you can open that follow up issue would be appreciated

@ChiefMilesEdgeworth
Copy link
Contributor Author

Sure thing. I'll post the output of the errors with the issue. Thanks for the quick response!

@jreback jreback merged commit a2d5579 into pandas-dev:master Oct 6, 2019
@jreback
Copy link
Contributor

jreback commented Oct 6, 2019

thanks @Nabel0721 I closed the original issue, but if there are still errors, pls open a new one (as @WillAyd indicated).

@ChiefMilesEdgeworth ChiefMilesEdgeworth deleted the Add-SA02,SA03-to-CI-build branch October 6, 2019 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix format of the See Also descriptions
3 participants