-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Added SA01, SA02, and SA03 error checks to the Travis CI Build #28789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Added SA01, SA02, and SA03 error checks to the Travis CI Build #28789
Conversation
These error types no longer show errors on master, so they're ready to be turned on for builds.
lgtm. This doesn't fully close the issue referenced though right? Would SA01 and SA04 still not be required to fully close? |
Those weren't part of the errors being run in that issue. If you'd like I can look into if those are passing to, and if not edit the PR so it addresses the issue instead of closing it. |
Yea I guess if you can check on those would be great - they are all part of the "See Also" validation so I think would make sense to include if not a lot of effort |
Looks like SA01 is clean too, but SA04 has a lot of issues. I'll add SA01 to the checks run for now. We should open a new issue for just SA04, so people can focus down on just that error. |
SA01 is also error-free right now, so I'm adding it as well.
Sounds good to me - if you can open that follow up issue would be appreciated |
Sure thing. I'll post the output of the errors with the issue. Thanks for the quick response! |
thanks @Nabel0721 I closed the original issue, but if there are still errors, pls open a new one (as @WillAyd indicated). |
These error types no longer show errors on master, so they're ready to be turned on for builds.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff