-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Misc typos fixed in docs and code comments #28785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix some typo
@@ -4551,7 +4551,7 @@ | |||
58101955,"TACO OR TOSTADA SALAD, MEATLESS W/ SOUR CREAM","Taco or tostada salad, meatless with sour cream" | |||
58103120,"TAMALE WITH MEAT","Tamale with meat" | |||
58103130,"TAMALE WITH CHICKEN","Tamale with chicken" | |||
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this causing the CI failure? Id be OK with leaving this unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like yes, this is causing the failure. Please revert.
Small comment, generally looks good |
@@ -4551,7 +4551,7 @@ | |||
58101955,"TACO OR TOSTADA SALAD, MEATLESS W/ SOUR CREAM","Taco or tostada salad, meatless with sour cream" | |||
58103120,"TAMALE WITH MEAT","Tamale with meat" | |||
58103130,"TAMALE WITH CHICKEN","Tamale with chicken" | |||
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style" | |||
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Caribbean Style" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Caribbean Style" | |
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style" |
I guess this is for tests with SAS, that need to march a SAS file with a typo. Let's revert here, and feel free to fix it in a separate PR for here, and for the SAS file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know if is ok
@garanews can you apply the fix suggested by datapythonista? this should be about ready otherwise |
lgtm cc @datapythonista |
Thanks a lot for fixing all those @garanews If you want to open an issue for the typo in the csv that would be great. And also if you want to fix it yourself. Btw, opening PRs from master is not a good practice, you'll have problems if you try to work in something else in parallel while the PR is being reviewed. Better to create a branch for every PR. |
Fix some typo