Skip to content

DOC: Misc typos fixed in docs and code comments #28785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2019
Merged

DOC: Misc typos fixed in docs and code comments #28785

merged 2 commits into from
Oct 29, 2019

Conversation

garanews
Copy link
Contributor

@garanews garanews commented Oct 4, 2019

Fix some typo

Fix some typo
@WillAyd WillAyd added the Docs label Oct 4, 2019
@@ -4551,7 +4551,7 @@
58101955,"TACO OR TOSTADA SALAD, MEATLESS W/ SOUR CREAM","Taco or tostada salad, meatless with sour cream"
58103120,"TAMALE WITH MEAT","Tamale with meat"
58103130,"TAMALE WITH CHICKEN","Tamale with chicken"
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this causing the CI failure? Id be OK with leaving this unchanged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like yes, this is causing the failure. Please revert.

@jbrockmendel
Copy link
Member

Small comment, generally looks good

@@ -4551,7 +4551,7 @@
58101955,"TACO OR TOSTADA SALAD, MEATLESS W/ SOUR CREAM","Taco or tostada salad, meatless with sour cream"
58103120,"TAMALE WITH MEAT","Tamale with meat"
58103130,"TAMALE WITH CHICKEN","Tamale with chicken"
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style"
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Caribbean Style"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Caribbean Style"
58103200,"TAMALE, PLAIN, MEATLESS, NO SAUCE, PR STYLE","Tamale, plain, meatless, no sauce, Puerto Rican style or Carribean Style"

I guess this is for tests with SAS, that need to march a SAS file with a typo. Let's revert here, and feel free to fix it in a separate PR for here, and for the SAS file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if is ok

@jbrockmendel
Copy link
Member

@garanews can you apply the fix suggested by datapythonista? this should be about ready otherwise

@jbrockmendel
Copy link
Member

lgtm cc @datapythonista

@datapythonista datapythonista changed the title Fix some typo DOCS: Misc typos fixed in docs and code comments Oct 29, 2019
@datapythonista datapythonista merged commit c21235b into pandas-dev:master Oct 29, 2019
@datapythonista datapythonista changed the title DOCS: Misc typos fixed in docs and code comments DOC: Misc typos fixed in docs and code comments Oct 29, 2019
@datapythonista
Copy link
Member

Thanks a lot for fixing all those @garanews

If you want to open an issue for the typo in the csv that would be great. And also if you want to fix it yourself.

Btw, opening PRs from master is not a good practice, you'll have problems if you try to work in something else in parallel while the PR is being reviewed. Better to create a branch for every PR.

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants