-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Allow cast from cat to extension dtype #28762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
682d4a9
BUG: Allow cast from cat to extension dtype
b91ba05
Ignore type check
1074540
Move condition
580a30f
Parametrize test over dtypes
1fdc8da
Update test
d24c5c1
Add merge test
377810a
Add datetime extension dtype test
2168e69
Merge branch 'master' into cat-to-ext
4ed0915
Add to test cases
300e037
Clean up merge test
2618540
Add merge note
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,7 @@ | |
) | ||
from pandas.core.base import NoNewAttributesMixin, PandasObject, _shared_docs | ||
import pandas.core.common as com | ||
from pandas.core.construction import extract_array, sanitize_array | ||
from pandas.core.construction import array, extract_array, sanitize_array | ||
from pandas.core.missing import interpolate_2d | ||
from pandas.core.sorting import nargsort | ||
|
||
|
@@ -520,6 +520,8 @@ def astype(self, dtype: Dtype, copy: bool = True) -> ArrayLike: | |
if dtype == self.dtype: | ||
return self | ||
return self._set_dtype(dtype) | ||
if is_extension_array_dtype(dtype): | ||
return array(self, dtype=dtype, copy=copy) # type: ignore # GH 28770 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe the following an elif |
||
if is_integer_dtype(dtype) and self.isna().any(): | ||
msg = "Cannot convert float NaN to integer" | ||
raise ValueError(msg) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add another note about the merge issue (which was the OP); IIRC its the same issue number. otherwise lgtm, ping on green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback Included a note for the merge issue, let me know if it looks good and thanks for the review