Skip to content

TST: Fix maybe_promote xfails #28754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 6, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

Fix a handful of these, clean up a bunch of others.

@jbrockmendel
Copy link
Member Author

This gets towards the end of what I can clean up without major changes. I'm inclined to try to remove the box=True cases and disallow ndarray fill_value arg, which would simplify the code a bit and the tests a ton. AFAICT we can do this without breaking any existing tests (outside of tests for dtypes.cast), but I don't think we can rule out it being possible to get there in the handful of places where maybe_promote is called.

@gfyoung gfyoung added Clean Testing pandas testing functions or related to the test suite labels Oct 2, 2019
@jbrockmendel
Copy link
Member Author

Reverted unnecessary test cleanup to make a smaller diff

@jreback jreback added this to the 1.0 milestone Oct 5, 2019
@jreback
Copy link
Contributor

jreback commented Oct 5, 2019

maybe rebase this as we merged a few other things, ping on green.

@jbrockmendel
Copy link
Member Author

sure. heads up: im out of town until monday, will be less responsive than usual

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 35c4dce into pandas-dev:master Oct 6, 2019
@jreback
Copy link
Contributor

jreback commented Oct 6, 2019

thanks

@jbrockmendel jbrockmendel deleted the maybe_promote7 branch October 6, 2019 22:21
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants