Skip to content

TST: add test to confirm adding 'm' to a Series of strings does not error #28736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2019
Merged

TST: add test to confirm adding 'm' to a Series of strings does not error #28736

merged 2 commits into from
Oct 2, 2019

Conversation

kognate
Copy link
Contributor

@kognate kognate commented Oct 1, 2019

adds a test to check for regressions later. Replacement PR for #28732

@kognate
Added test to confirm fix for pandas-dev#28658
d4bacd9 
adds a test to check for regressions later.
@jreback jreback changed the title Added test to confirm fix for #28658 Error when adding 'm' to a Series of strings Oct 1, 2019
@jreback jreback added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Oct 1, 2019
@jreback jreback added this to the 1.0 milestone Oct 1, 2019
WillAyd
WillAyd approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche changed the title Error when adding 'm' to a Series of strings TST: add test to confirm adding 'm' to a Series of strings does not error Oct 2, 2019
jorisvandenbossche
jorisvandenbossche approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jorisvandenbossche jorisvandenbossche merged commit b298696 into pandas-dev:master Oct 2, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@kognate @proost
TST: add test to confirm adding 'm' to a Series of strings does not e…
bc4ac21 
…rror (pandas-dev#28736)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@kognate @proost
TST: add test to confirm adding 'm' to a Series of strings does not e…
d97dcda 
…rror (pandas-dev#28736)
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@kognate
TST: add test to confirm adding 'm' to a Series of strings does not e…
3f67cf6 
…rror (pandas-dev#28736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Error when adding 'm' to a Series of strings
4 participants
@kognate @WillAyd @jorisvandenbossche @jreback