API: Change matplotlib formatter registration #28722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Oct 1, 2019
| @@ -71,27 +59,12 @@ def test_register_by_default(self): | |||
| call = [sys.executable, "-c", code] | |||
| assert subprocess.check_call(call) == 0 | |||
|
|
|||
| def test_warns(self): | |||
| plt = pytest.importorskip("matplotlib.pyplot") | |||
There was a problem hiding this comment.
is there a way to check that we have not registered things?
There was a problem hiding this comment.
Hmm, we do that indirectly with the code check... If we haven't imported matplotlib, then we know we haven't registered anything.
WillAyd
reviewed
Oct 2, 2019
| def register(explicit=True): | ||
| # Renamed in pandas.plotting.__init__ | ||
| global _WARN | ||
| def pandas_converters_deco(func): |
There was a problem hiding this comment.
Is there a reason why this needs to be a decorator? Perhaps a style preference but I would find it easier to grok if the context manager was used where required in the actual plotting methods
There was a problem hiding this comment.
No need. I mainly did it for a smaller diff / less indentation :)
Happy to go either way here.
added 2 commits
October 10, 2019 10:23
|
All green here now. |
jorisvandenbossche
approved these changes
Oct 18, 2019
datapythonista
approved these changes
Oct 19, 2019
|
Should be good to go. |
|
Thanks! |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
Background: pandas used to register formatters for Period, datetime, date, and time. This formatters affected plots created using matplotlib only, not pandas. For various reasons (including import time) we don't want to do this on an
import pandas.A minimal change would be to just not do the registration on
import pandas. Users would either manually do it, or pandas does it automatically when we do DataFrame.plot. The downside of pandas doing it automatically is then in the followingfig1 and fig2 will be different because pandas has implicilty registered formatters.
The
autooption will automatically register the formatters, make the plot, then deregister the formatters.Closes #18720