Skip to content

precursor to Split out test_pytables.py to sub-module of tests #28715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Oct 1, 2019

Conversation

tolaa001
Copy link
Contributor

@tolaa001 tolaa001 commented Oct 1, 2019

Next I plan to create a test file for TestTimezones class and make the test functional so the class itself is no longer required.
Once this is running fine, I will then apply similar approach to the other bigger classes.

@pep8speaks
Copy link

pep8speaks commented Oct 1, 2019

Hello @tolaa001! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-01 13:14:18 UTC

@simonjayhawkins simonjayhawkins added IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite labels Oct 1, 2019
@simonjayhawkins
Copy link
Member

thanks @tolaa001 for the PR!

just to be clear, there is a non-trivial amount of effort for #18498 and will require several PRs.

this PR is to add a couple of fixtures in order to eliminate the Base class. In this PR, the fixtures replicate the current unittest setup and teardown methods only and improving these fixtures and adding additional fixtures for some of the assertions will come later.

the next PR would be to split on complete classes. There are 3 test classes in pandas/tests/io/pytables/test_pytables.py, TestHDFStore, TestHDFComplexValues and TestTimezones.

so the first split would split TestHDFComplexValues and TestTimezones from test_pytables.py into test_complex.py and test_timezones.py (and move the two fixtures created here to a conftest.py) but this would need to be a seperate PR with code moved and miniamal code changes to make the diff simpler to review.

This PR is preparing for that split.

TestHDFStore could then be split further once the classes have been separated.

@simonjayhawkins simonjayhawkins changed the title WIP: Split out test_pytables.py to sub-module of tests Split out test_pytables.py to sub-module of tests Oct 1, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Oct 1, 2019
@simonjayhawkins simonjayhawkins changed the title Split out test_pytables.py to sub-module of tests precursor to Split out test_pytables.py to sub-module of tests Oct 1, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this is fine, next steps would be to move test_pytables to a sub-dir and split out a conftest.py, then start moving things to separate files.

@jreback jreback merged commit 02675e3 into pandas-dev:master Oct 1, 2019
@simonjayhawkins
Copy link
Member

next steps would be to move test_pytables to a sub-dir

already a sub-dir so no need to nest further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO HDF5 read_hdf, HDFStore Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants