-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
precursor to Split out test_pytables.py to sub-module of tests #28715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit d20973e.
…tion into an argument
thanks @tolaa001 for the PR! just to be clear, there is a non-trivial amount of effort for #18498 and will require several PRs. this PR is to add a couple of fixtures in order to eliminate the Base class. In this PR, the fixtures replicate the current unittest setup and teardown methods only and improving these fixtures and adding additional fixtures for some of the assertions will come later. the next PR would be to split on complete classes. There are 3 test classes in so the first split would split This PR is preparing for that split.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this is fine, next steps would be to move test_pytables to a sub-dir and split out a conftest.py, then start moving things to separate files.
already a sub-dir so no need to nest further. |
@simonjayhawkins as discussed this is the pre work to splitting this large test file into smaller files. So far, I have fixturised the class base class and updated methods using self.path from base to use the setup_path fixture instead.
Next I plan to create a test file for TestTimezones class and make the test functional so the class itself is no longer required.
Once this is running fine, I will then apply similar approach to the other bigger classes.