BUG: restore limit in RangeIndex.get_indexer #28671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Bug
Indexing
|
thanks @simonjayhawkins updated reflecting reviews! |
simonjayhawkins
requested changes
Sep 30, 2019
There was a problem hiding this comment.
Thanks @charlesdong1991 i think a few more changes and that's it!
|
Good morning @simonjayhawkins ! and thanks for your reviews! All changed based on your reviews! Have a great day! ^^ |
jreback
requested changes
Sep 30, 2019
pandas/tests/indexes/test_range.py
Outdated
| @@ -1037,3 +1045,19 @@ def test_engineless_lookup(self): | |||
| assert idx.get_loc("a") == -1 | |||
|
|
|||
| assert "_engine" in idx._cache | |||
|
|
|||
| def test_reindex_limit(self): | |||
| # GH 28631 | |||
There was a problem hiding this comment.
this doesn’t belong here
rather with other dataframe reindex tests
look in tests/frame
There was a problem hiding this comment.
okay, move to tests/frame/test_indexing
toobaz
reviewed
Sep 30, 2019
jschendel
reviewed
Sep 30, 2019
jschendel
approved these changes
Sep 30, 2019
jorisvandenbossche
approved these changes
Oct 1, 2019
jorisvandenbossche
changed the title
|
@charlesdong1991 thanks a lot for the PR! |
|
@meeseeksdev backport 0.25.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 1, 2019
josibake
pushed a commit
to josibake/pandas
that referenced
this pull request
Oct 1, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff