Skip to content

BUG: fix broken error message in ujson.encode() (GH18878) #28666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2019
Merged

BUG: fix broken error message in ujson.encode() (GH18878) #28666

merged 3 commits into from
Oct 6, 2019

Conversation

rlamy
Copy link
Contributor

@rlamy rlamy commented Sep 28, 2019 •
edited
Loading

@WillAyd WillAyd added Error Reporting Incorrect or improved errors from pandas IO JSON read_json, to_json, json_normalize labels Sep 28, 2019
@WillAyd WillAyd added this to the 1.0 milestone Sep 28, 2019
WillAyd
WillAyd requested changes Sep 28, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add a whatsnew note for 1.0.0 as well?

simonjayhawkins
simonjayhawkins reviewed Sep 28, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlamy Thanks for the PR. lgtm. couple of suggestions.

simonjayhawkins
simonjayhawkins approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @WillAyd

@jreback jreback merged commit 0db85e9 into pandas-dev:master Oct 6, 2019
@jreback
Copy link
Contributor

jreback commented Oct 6, 2019

thanks @rlamy

@rlamy rlamy deleted the issue-18878 branch October 8, 2019 13:59
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@rlamy @proost
BUG: fix broken error message in ujson.encode() (GH18878) (pandas-dev…
2c5ed40 
…#28666)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@rlamy @proost
BUG: fix broken error message in ujson.encode() (GH18878) (pandas-dev…
76bb201 
…#28666)
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@rlamy
BUG: fix broken error message in ujson.encode() (GH18878) (pandas-dev…
1d96044 
…#28666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd requested changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO JSON read_json, to_json, json_normalize
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

str vs bytes confusion in ujson on Python 3
4 participants
@rlamy @jreback @WillAyd @simonjayhawkins