-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
accept a dictionary in plot colors #28659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @Leostayner! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-19 08:16:24 UTC |
can you merge master |
2637a49
to
49c20a4
Compare
@jreback, Merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a whatsnew note for v1.0.0 and update the docstring for .plot
to reflect this?
0e6ef75
to
ea2a836
Compare
Updated whatsnew. Now where should I update the pandas/pandas/plotting/_core.py Line 855 in c0050e0
pandas/pandas/plotting/_core.py Line 924 in c0050e0
|
can you merge master |
Hi @Leostayner - sorry to chase you up, just wanted to ask whether you're still working on this PR :) |
@MarcoGorelli - given the silence, I think you're okay to finish this up if you want. |
Sure. Looks like it's gone stale, so I've taken it forward in #31071 (note to OP: you're welcome to reopen this if you want to keep working on it) |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Line/bar plot accepts color by dictonary.
@elisamalzoni