Skip to content

accept a dictionary in plot colors #28659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Leostayner
Copy link

@Leostayner Leostayner commented Sep 27, 2019

Line/bar plot accepts color by dictonary.
@elisamalzoni

@gfyoung gfyoung added the Visualization plotting label Sep 28, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 1, 2019

Hello @Leostayner! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-19 08:16:24 UTC

@jreback jreback changed the title Fixes issue #8193 accept a dictionary in plot colors Oct 2, 2019
@jreback
Copy link
Contributor

jreback commented Oct 18, 2019

can you merge master

@Leostayner
Copy link
Author

@jreback, Merged!

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a whatsnew note for v1.0.0 and update the docstring for .plot to reflect this?

@Leostayner
Copy link
Author

Updated whatsnew. Now where should I update the .plot docstring? Here is where I think it should be, is it right?

def line(self, x=None, y=None, **kwargs):

def bar(self, x=None, y=None, **kwargs):

@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

can you merge master

@MarcoGorelli
Copy link
Member

MarcoGorelli commented Jan 16, 2020

Hi @Leostayner - sorry to chase you up, just wanted to ask whether you're still working on this PR :)

@gfyoung
Copy link
Member

gfyoung commented Jan 16, 2020

@MarcoGorelli - given the silence, I think you're okay to finish this up if you want.

@MarcoGorelli
Copy link
Member

Sure. Looks like it's gone stale, so I've taken it forward in #31071 (note to OP: you're welcome to reopen this if you want to keep working on it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a dictionary of columns names and colors
6 participants