BUG: Make DataFrame not hardcode it's own constructor in the code. Issue #2859 #2865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all occurrences of `return DataFrame` to `return self._constructor` and changed the latter to return `self.__class__` rather than `DataFrame` by default. Also made static methods like `DataFrame.from_dict` work on the `cls` passed to them rather than on hard-coded `DataFrame`. This is a minimal quick win on the cases described in Issue pandas-dev#2859. A formal approach to make classes friendly to subclassing might still be needed, see discussion in the case.
wesm
added a commit
that referenced
this pull request
Mar 28, 2013
|
Quick "hand merge". This won't solve the issue but helps in some cases |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Make DataFrame not hardcode it's own constructor in the code. Issue
Changed all occurrences of
return DataFrametoreturn self._constructorand changed the latter to returnself.__class__rather than
DataFrameby default.Also made static methods like
DataFrame.from_dictwork on theclspassed to them rather than on hard-codedDataFrame.This is a minimal quick win on the cases described in Issue #2859.
A formal approach to make classes friendly to subclassing might still be
needed, see discussion in the case.