CLN: streamline Series _construct_result calls #28637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 26, 2019
pandas/core/ops/__init__.py
Outdated
| @@ -566,13 +566,22 @@ def _align_method_SERIES(left, right, align_asobject=False): | |||
| return left, right | |||
|
|
|||
|
|
|||
| def _construct_result(left, result, index, name, dtype=None): | |||
| def _construct_result(left, result, index, name): | |||
There was a problem hiding this comment.
can you add a doc-string / types
There was a problem hiding this comment.
request addressed + green
jorisvandenbossche
approved these changes
Sep 26, 2019
|
thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, the three Series methods in
ops.__init__are just about in sync, the last holdout being alignment behavior in the comparison method.