Skip to content

REF: Assert json roundtrip equal #28626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 27, 2019
Merged

REF: Assert json roundtrip equal #28626

merged 6 commits into from
Sep 27, 2019

Conversation

bganglia
Copy link
Contributor

Replaces a some frequently repeated lines with a function.

@bganglia
Add assert_json_roundtrip_equal function
94e528a 
Add assert_json_roundtrip_equal function to make repeated pattern modular
@bganglia
assert_json_roundtrip_equal calls
7cb5f85 
Replaced repeated code with calls to assert_json_roundtrip_equal
@pep8speaks
Copy link

pep8speaks commented Sep 26, 2019 •
edited
Loading

Hello @bganglia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-27 21:29:07 UTC

@jbrockmendel
Copy link
Member

This is really nice, thanks. Looks like the linter is finding trailing whitespace that you need to delete

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Sep 26, 2019
@WillAyd WillAyd added this to the 1.0 milestone Sep 26, 2019
@bganglia
Remove trailing whitespace
318669d 
Remove trailing whitespace
@bganglia
Remove trailing whitespace
e3244b8 
Remove trailing whitespace
WillAyd
WillAyd requested changes Sep 27, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think test_roundtrip_intframe is the one outstanding - can you use this function therein as well? After that lgtm can get this merged - thanks for the PR!

@bganglia
Copy link
Contributor Author

Thank you, yes. I will do that now.

@WillAyd WillAyd merged commit 49b4b0a into pandas-dev:master Sep 27, 2019
@WillAyd
Copy link
Member

WillAyd commented Sep 27, 2019

Thanks @bganglia nice PR and great first contribution. Would welcome more PRs to tackle other issues!

josibake pushed a commit to josibake/pandas that referenced this pull request Sep 29, 2019
@bganglia
REF: Assert json roundtrip equal (pandas-dev#28626)
6b622d1
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@bganglia @proost
REF: Assert json roundtrip equal (pandas-dev#28626)
b4db571
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@bganglia @proost
REF: Assert json roundtrip equal (pandas-dev#28626)
378686b
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@bganglia
REF: Assert json roundtrip equal (pandas-dev#28626)
76f9e43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Create helper function in pandas/tests/io/json/test_pandas.py
4 participants
@bganglia @pep8speaks @jbrockmendel @WillAyd