BUG: value_counts can handle the case even with empty groups (#28479) #28607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev#28479) * If applying rep to recons_labels go fail, use ids which has no consecutive duplicates instead.
|
Hello @0xF4D3C0D3! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
I'm sorry. I'll issue PR later again because I made some mistakes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consecutive duplicates instead.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxuancong84 found that value_counts() crashes if
groupbyobject contains empty groups.However, even though I made the construction of DataFrame don't skip empty rows, it still crashed.
Till then, I already tried in many ways though, in this time I tried to correct the callee
self.grouper.recons_labels. After several tests, I found that If freq ofGrouperis too long so that it has empty groups in some periods then it crashes. And also have found that this is solved by usingidswhich has no consecutive duplicates instead ofself.grouper.recons_labels.