REF/TST: Corner cases for op(DataFrame, Series) #28600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 25, 2019
pandas/core/ops/__init__.py
Outdated
| return self._constructor( | ||
| data=self._series, index=self.index, columns=self.columns | ||
| ) | ||
|
|
||
| # default axis is columns |
There was a problem hiding this comment.
i would now remove the else as this is the default case
There was a problem hiding this comment.
sure. follow-up is going to re-write this func anyway
|
|
||
|
|
||
| def test_frame_with_zero_len_series_corner_cases(): | ||
| # easy all-float case |
There was a problem hiding this comment.
can you reference this issue in these.
jreback
added
the
Compat
|
gentle ping. The follow-ups to this are both a) really nice code-removals and b) orthogonal to the rest of the current ops stuff. |
|
great thanks |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two special cases in
_combine_series_framethat are never tested ATM. This adds tests for them, then notes that the special case handling code is unnecessary and this can now fall through to the general case code. In a follow-up, we'll be able to simplify _combine_series_frame further, but for now I want to keep the changed logic obvious.Also note that the removed
is actually wrong in the non-float test case in L681-685 in the test file.