-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: update fixing unknown parameters errors (error code PR02) #28567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update fixing unknown parameters errors (error code PR02) #28567
Conversation
pandas/plotting/_core.py
Outdated
@@ -1148,7 +1148,7 @@ def kde(self, bw_method=None, ind=None, **kwargs): | |||
1000 equally spaced points are used. If `ind` is a NumPy array, the | |||
KDE is evaluated at the points passed. If `ind` is an integer, | |||
`ind` number of equally spaced points are used. | |||
**kwds : optional | |||
**kwargs : optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should the "optional" part be consistent across all of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing those, lgtm
but if you don't mind removing the optional in this same PR, that would be great (also ok in a follow up)
Thanks for approving this Marc 😊. I will do this once am reunited with my laptop tomorrow evening. Also thanks for all your advise at the Iwoca meet up last week. |
Any reason why we don't change all instances of |
I'm not sure what's wrong with the CI. You'll have to debug |
@datapythonista can you please providing me with some guidance as I am unsure why the CI build is failing? |
@tolaa001 Thanks a lot for the contribution! |
Documentation update fixing some of the methods with a PR-2 error code which involved updating **kwds to **kwargs
No tests required
The data frame.plot methods now have the docstring arguments updated from **kwds to **kwargs to match the method signature and exclude them from the PR02 errors: