BENCH: Add rolling apply benchmarks #28566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Benchmark
gfyoung
approved these changes
Sep 22, 2019
| @@ -25,6 +25,25 @@ def peakmem_rolling(self, constructor, window, dtype, method): | |||
| getattr(self.roll, method)() | |||
|
|
|||
|
|
|||
| class Apply: | |||
| params = ( | |||
| ["DataFrame", "Series"], | |||
There was a problem hiding this comment.
any reason not to just put (pd.DataFrame, pd.Series) and avoid the getattr?
There was a problem hiding this comment.
It was the nicest way to have it label nicely in the params and not be an if/else in the setup. Plus the getattr is in the setup so it won't impact the benchmark time.
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BENCH: Add rolling apply benchmarks * black
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BENCH: Add rolling apply benchmarks * black
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
* BENCH: Add rolling apply benchmarks * black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff