CLN: Assorted cleanups #28563
Merged
CLN: Assorted cleanups #28563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Clean
Internals
gfyoung
reviewed
Sep 22, 2019
| @@ -743,7 +742,7 @@ def value_counts( | |||
|
|
|||
| else: | |||
|
|
|||
| if is_extension_array_dtype(values) or is_sparse(values): | |||
| if is_extension_array_dtype(values): | |||
There was a problem hiding this comment.
For everyone's edification: why can we remove this check?
There was a problem hiding this comment.
is_sparse is a subset of is_extension_array_dtype
gfyoung
reviewed
Sep 22, 2019
| subarr = dtype.construct_array_type()( | ||
| arr, dtype.categories, ordered=dtype._ordered | ||
| ) | ||
| elif is_extension_array_dtype(dtype): | ||
| # create an extension array from its dtype | ||
| dtype = cast(ExtensionDtype, dtype) |
There was a problem hiding this comment.
For everyone's edification: why are we doing this? Same for the similar cast a few lines above.
There was a problem hiding this comment.
This is to keep mypy from complaining
|
thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.