Skip to content

ENH: Add dta 119 reading to StataReader #28542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Sep 19, 2019

Add requirements for reading 119 format files

@bashtage
Copy link
Contributor Author

Minor code changes needed to support reading Stata DTA format 119. The hard part is testing since this format is only used when a file has more than 32K variables, and so the test file hits this size. This test isn't that fast (~20s).

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm OK. I assume the test length is just spent in reading that many rows?

@WillAyd WillAyd added the IO Stata read_stata, to_stata label Sep 20, 2019
@bashtage bashtage force-pushed the stata-119-reader branch 2 times, most recently from 044c08c to 26c8ffa Compare September 20, 2019 07:57
Add requirements for reading 119 format files
@bashtage
Copy link
Contributor Author

Hmm OK. I assume the test length is just spent in reading that many rows?

Yes, 32,999 columns. Have marked it slow.

@jreback jreback added this to the 1.0 milestone Sep 20, 2019
@jreback jreback merged commit e8cd32f into pandas-dev:master Sep 20, 2019
@jreback
Copy link
Contributor

jreback commented Sep 20, 2019

thanks @bashtage

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Add requirements for reading 119 format files
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Add requirements for reading 119 format files
@bashtage bashtage deleted the stata-119-reader branch December 19, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Stata read_stata, to_stata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reading Stata .dta file format 119
3 participants