CLN+TST: Catch specific exception in equals #28532
Conversation
106 on master. A handful of those are correct as is, not sure how many (maybe we could alias Also a handful of |
|
Is this a case where we want to be broad in what we catch? Having equality checks never raise is convenient. |
That's not unreasonable. I lean towards being specific because it surfaces other bugs (like passing MultiIndex raising the wrong exception). |
|
I generally dislike |
| @@ -1918,6 +1918,9 @@ def sequence_to_dt64ns( | |||
| tz = validate_tz_from_dtype(dtype, tz) | |||
|
|
|||
| if isinstance(data, ABCIndexClass): | |||
| if data.nlevels > 1: | |||
| # Without this check, data._data below is None | |||
| raise TypeError("Cannot create a DatetimeArray from a MultiIndex.") | |||
There was a problem hiding this comment.
we should have an index method which does this no?
There was a problem hiding this comment.
For the check or the raising? The check could be isinstance(data, ABCMultiIndex). No strong preference.
There was a problem hiding this comment.
no, something that does the right thing on an Index/MultiIndex, e.g. that gets (data._data) on an index and just passes thru on a MI
There was a problem hiding this comment.
I think we want to move to use the extract_array pattern here, but that currently raises ValueError on MultiIndex (where we want to raise TypeError here)
There was a problem hiding this comment.
ok the reason I am harping on this is its an inconsistency between Index and MultiIndex. ok on merging this and creating an issue / followup ?
There was a problem hiding this comment.
creating an issue / followup ?
yes
|
k cool |
No description provided.