TST: parametrize test_expressions #28493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 18, 2019
| assert used_numexpr, "Did not use numexpr as expected." | ||
| tm.assert_equal(expected, result) | ||
|
|
||
| def run_frame(self, df, other, run_binary=True): |
There was a problem hiding this comment.
Is this function even necessary? I think this could be cleaned up a lot if all of these functions were just parametrized instead of indirected across a few functions
There was a problem hiding this comment.
I think we can clean it up further if we get the run_binary thing working more consistently
|
thanks @jbrockmendel definite improvement on the existing, I am sure you will be pushing more cleanups for this :-> |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and an unrelated excel test cleanup that slipped in somehow