TST: Parametrize and cleanup Exception

pandas/tests/arithmetic/test_datetime64.py

@@ -78,17 +78,6 @@ def assert_invalid_comparison(left, right, box):
         right >= left
 
 
-def assert_all(obj):
-    """
-    Test helper to call call obj.all() the appropriate number of times on
-    a Series or DataFrame.
-    """
-    if isinstance(obj, pd.DataFrame):
-        assert obj.all().all()
-    else:
-        assert obj.all()
-
-
 # ------------------------------------------------------------------
 # Comparisons
 
@@ -578,17 +567,17 @@ def test_comparison_tzawareness_compat(self, op, box_df_fail):
             op(dz, np.array(list(dr), dtype=object))
 
         # The aware==aware and naive==naive comparisons should *not* raise
-        assert_all(dr == dr)
-        assert_all(dr == list(dr))
-        assert_all(list(dr) == dr)
-        assert_all(np.array(list(dr), dtype=object) == dr)
-        assert_all(dr == np.array(list(dr), dtype=object))
-
-        assert_all(dz == dz)
-        assert_all(dz == list(dz))
-        assert_all(list(dz) == dz)
-        assert_all(np.array(list(dz), dtype=object) == dz)
-        assert_all(dz == np.array(list(dz), dtype=object))
+        assert np.all(dr == dr)
+        assert np.all(dr == list(dr))
+        assert np.all(list(dr) == dr)
+        assert np.all(np.array(list(dr), dtype=object) == dr)
+        assert np.all(dr == np.array(list(dr), dtype=object))
+
+        assert np.all(dz == dz)
+        assert np.all(dz == list(dz))
+        assert np.all(list(dz) == dz)
+        assert np.all(np.array(list(dz), dtype=object) == dz)
+        assert np.all(dz == np.array(list(dz), dtype=object))
 
     @pytest.mark.parametrize(
         "op",
@@ -606,12 +595,12 @@ def test_comparison_tzawareness_compat_scalars(self, op, box_with_array):
         ts = pd.Timestamp("2000-03-14 01:59")
         ts_tz = pd.Timestamp("2000-03-14 01:59", tz="Europe/Amsterdam")
 
-        assert_all(dr > ts)
+        assert np.all(dr > ts)
         msg = "Cannot compare tz-naive and tz-aware"
         with pytest.raises(TypeError, match=msg):
             op(dr, ts_tz)
 
-        assert_all(dz > ts_tz)
+        assert np.all(dz > ts_tz)
         with pytest.raises(TypeError, match=msg):
             op(dz, ts)
 

pandas/tests/frame/test_indexing.py

@@ -2172,10 +2172,9 @@ def test_nested_exception(self):
         index[0] = ["a", "b"]
         df.index = index
 
-        try:
-            repr(df)
-        except Exception as e:
-            assert type(e) != UnboundLocalError
+        # Note: this used to be a test that any exception that _is_
+        #  raised by repr is _not_ an UnboundLocalError.
+        repr(df)
 
     @pytest.mark.parametrize(
         "method,expected_values",

pandas/tests/indexing/common.py

@@ -212,7 +212,8 @@ def _print(result, error=None):
 
                 try:
                     xp = self.get_result(obj, method2, k2, a)
-                except Exception:
+                except (KeyError, IndexError):
+                    # TODO: why is this allowed?
                     result = "no comp"
                     _print(result)
                     return
@@ -222,10 +223,8 @@ def _print(result, error=None):
                 try:
                     if is_scalar(rs) and is_scalar(xp):
                         assert rs == xp
-                    elif xp.ndim == 1:
-                        tm.assert_series_equal(rs, xp)
-                    elif xp.ndim == 2:
-                        tm.assert_frame_equal(rs, xp)
+                    else:
+                        tm.assert_equal(rs, xp)
                     result = "ok"
                 except AssertionError as e:
                     detail = str(e)
@@ -242,7 +241,7 @@ def _print(result, error=None):
 
             except AssertionError:
                 raise
-            except Exception as detail:
+            except (IndexError, TypeError, KeyError) as detail:
 
                 # if we are in fails, the ok, otherwise raise it
                 if fails is not None:

pandas/tests/series/test_api.py

@@ -697,6 +697,7 @@ def test_dt_accessor_api_for_categorical(self):
             ("floor", ("D",), {}),
             ("ceil", ("D",), {}),
             ("asfreq", ("D",), {}),
+            # FIXME: don't leave commented-out
             # ('tz_localize', ("UTC",), {}),
         ]
         _special_func_names = [f[0] for f in special_func_defs]
@@ -729,20 +730,11 @@ def test_dt_accessor_api_for_categorical(self):
                     res = getattr(c.dt, func)(*args, **kwargs)
                     exp = getattr(s.dt, func)(*args, **kwargs)
 
-                if isinstance(res, DataFrame):
-                    tm.assert_frame_equal(res, exp)
-                elif isinstance(res, Series):
-                    tm.assert_series_equal(res, exp)
-                else:
-                    tm.assert_almost_equal(res, exp)
+                tm.assert_equal(res, exp)
 
             for attr in attr_names:
-                try:
-                    res = getattr(c.dt, attr)
-                    exp = getattr(s.dt, attr)
-                except Exception as e:
-                    print(name, attr)
-                    raise e
+                res = getattr(c.dt, attr)
+                exp = getattr(s.dt, attr)
 
             if isinstance(res, DataFrame):
                 tm.assert_frame_equal(res, exp)