TST: Fix sqlite3 transactions test #28450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sqlite connection is already in transaction when the test starts, so when the test intentionally raises an exception, the entire transaction, including the table creation, gets rolled back, so there is no table to query. Wrapping the table CREATE statement in its own transaction avoids the issue.
mroeschke
added
the
Testing
mroeschke
approved these changes
Sep 14, 2019
| @@ -2213,8 +2211,6 @@ def test_to_sql_save_index(self): | |||
| self._to_sql_save_index() | |||
|
|
|||
| def test_transactions(self): | |||
| if PY36: | |||
| pytest.skip("not working on python > 3.5") | |||
There was a problem hiding this comment.
can we say anything about what it would take to fix this? should it be an xfail?
There was a problem hiding this comment.
Not sure I follow, those two lines were removed.
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
The sqlite connection is already in transaction when the test starts, so when the test intentionally raises an exception, the entire transaction, including the table creation, gets rolled back, so there is no table to query. Wrapping the table CREATE statement in its own transaction avoids the issue.
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
The sqlite connection is already in transaction when the test starts, so when the test intentionally raises an exception, the entire transaction, including the table creation, gets rolled back, so there is no table to query. Wrapping the table CREATE statement in its own transaction avoids the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sqlite connection is already in transaction when the test starts, so
when the test intentionally raises an exception, the entire transaction,
including the table creation, gets rolled back, so there is no table
to query. Wrapping the table CREATE statement in its own transaction
avoids the issue.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIs a whatsnew entry needed for a test fix issue?