Skip to content

DOC: fix docstring of core.comon.pipe (PR02) #28449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 15, 2019
Merged

DOC: fix docstring of core.comon.pipe (PR02) #28449

merged 3 commits into from
Sep 15, 2019

Conversation

AminooZ
Copy link
Contributor

@AminooZ AminooZ commented Sep 14, 2019

Solves:

  • Unknown parameters {kwargs, args}
  • Parameter "func" type should use "str" instead of "string"
  • Parameter "*args" description should start with a capital letter
  • Parameter "**kwargs" description should start with a capital letter
  • pandas.core.common.pipe : Unknown parameters {kwargs, args} in Fix PR02 issues in docstrings #27976

@gfyoung gfyoung added Docs Code Style Code style, linting, code_checks labels Sep 15, 2019
datapythonista
datapythonista approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @AminooZ

@jorisvandenbossche jorisvandenbossche changed the title Pandas.core.common.pipe docstring pr02 DOC: fix docstring of core.comon.pipe (PR02) Sep 15, 2019
@jorisvandenbossche jorisvandenbossche merged commit 08184ff into pandas-dev:master Sep 15, 2019
@jorisvandenbossche
Copy link
Member

@AminooZ thanks a lot!

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@AminooZ @proost
DOC: fix docstring of core.comon.pipe (PR02) (pandas-dev#28449)
99bdcda
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@AminooZ @proost
DOC: fix docstring of core.comon.pipe (PR02) (pandas-dev#28449)
aa24204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AminooZ @jorisvandenbossche @datapythonista @gfyoung