Skip to content

BLD: clean-up sdist creation #28432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 17, 2019
Merged

BLD: clean-up sdist creation #28432

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eda15eb
sdist cleanup
TomAugspurger Sep 13, 2019
50bc779
sdist cleanup
TomAugspurger Sep 13, 2019
6525f51
feather skips
TomAugspurger Sep 13, 2019
07d055d
Merge remote-tracking branch 'upstream/master' into sdist-cleanup
TomAugspurger Sep 16, 2019
845466f
update comment
TomAugspurger Sep 16, 2019
970d737
Merge branch 'sdist-cleanup' of https://github.com/TomAugspurger/pand…
TomAugspurger Sep 16, 2019
9ba4a93
conflict
TomAugspurger Sep 16, 2019
cee1aa7
note
TomAugspurger Sep 16, 2019
0f78867
Merge remote-tracking branch 'upstream/master' into sdist-cleanup
TomAugspurger Sep 16, 2019
08408e8
move out of bug fixes
TomAugspurger Sep 16, 2019
312f0de
Update v1.0.0.rst
WillAyd Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ graft pandas
global-exclude *.bz2
global-exclude *.csv
global-exclude *.dta
global-exclude *.feather
global-exclude *.gz
global-exclude *.h5
global-exclude *.html
Expand All @@ -24,7 +25,10 @@ global-exclude *.pickle
global-exclude *.png
global-exclude *.pyc
global-exclude *.pyd
global-exclude *.ods
global-exclude *.odt
global-exclude *.sas7bdat
global-exclude *.sav
global-exclude *.so
global-exclude *.xls
global-exclude *.xlsm
Expand Down
4 changes: 1 addition & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,12 +524,10 @@ def maybe_cythonize(extensions, *args, **kwargs):
"""
Render tempita templates before calling cythonize
"""
if len(sys.argv) > 1 and "clean" in sys.argv:
if "clean" in sys.argv or "sdist" in sys.argv:
# Avoid running cythonize on `python setup.py clean`
# See https://github.com/cython/cython/issues/1495
return extensions
elif "sdist" in sys.argv:
return extensions

numpy_incl = pkg_resources.resource_filename("numpy", "core/include")
# TODO: Is this really necessary here?
Expand Down