-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Remove error raise to allow same input function on the same column in named aggregation #28428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 1314059
fix conflicts
charlesdong1991 8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 07c6003
Merge remote-tracking branch 'upstream/master' into fix_issue_28426
charlesdong1991 495f4ca
Remove error raising
charlesdong1991 65f3a34
better test case
charlesdong1991 b985055
Fix test for series
charlesdong1991 fb43351
Add whatsnew
charlesdong1991 2bc05c3
better english
charlesdong1991 39d3aee
more accurate explanation
charlesdong1991 df51bf9
Remove unused imports
charlesdong1991 d162b3e
code change based on review
charlesdong1991 31e8079
fix test
charlesdong1991 7e87435
code change and reformat
charlesdong1991 1361236
move whatsnew to 1.0.0
charlesdong1991 3815507
add test
charlesdong1991 8a9c41b
bold change
charlesdong1991 6eeb978
remove unused comment
charlesdong1991 2ae946e
remove print
charlesdong1991 2e5fd6e
revert blank line change
charlesdong1991 b10b4b8
revert previous change
charlesdong1991 314eb28
revert unnecessary white space removal
charlesdong1991 3fc2d71
fix conflicts and merge master
charlesdong1991 fd485d7
fix tests
charlesdong1991 5817f5e
fix test
charlesdong1991 84f2734
fix conflict and repush
charlesdong1991 0e249fc
move to groupby section
charlesdong1991 6331a26
Merge remote-tracking branch 'upstream/master' into fix_issue_28426
charlesdong1991 5e1e4e0
merge master
charlesdong1991 f7a219c
fix test for multiindex
charlesdong1991 cef6d3a
reformatting
charlesdong1991 2c11c36
solve conflicts
charlesdong1991 5172f46
solve conflict
charlesdong1991 6c7ee71
merge master and fix conflict
charlesdong1991 90ba1b4
remove redundant and expand whatsnew note
charlesdong1991 8eaecee
Merge remote-tracking branch 'upstream/master' into fix_issue_28426
charlesdong1991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this to groupby (and the groupby one right below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your comment! moved! @jreback