ENH: MultiIndex.from_product infers names from inputs if not explicitly provided #28417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
One tiny comment: https://github.com/pandas-dev/pandas/pull/28417/files#r323883775 LGTM otherwise.
jreback
requested changes
Sep 12, 2019
pandas/core/indexes/multi.py
Outdated
| @@ -508,7 +510,9 @@ def from_product(cls, iterables, sortorder=None, names=None): | |||
| Level of sortedness (must be lexicographically sorted by that | |||
| level). | |||
| names : list / sequence of str, optional | |||
| Names for the levels in the index. | |||
| Names for the levels in the index. If not provided, these | |||
There was a problem hiding this comment.
can you add a versionadded directive here (1.0)
There was a problem hiding this comment.
Will do. Would it make sense to break it out into a ..versionchanged?
names : list / sequence of str, optional
Names for the levels in the index.
..versionchanged 1.0
If not explicitly provided, names will be inferred from the
elements of iterables if an element has a name attribute
|
do we have enough testing on |
TomAugspurger
approved these changes
Sep 13, 2019
Co-Authored-By: Tom Augspurger <[email protected]>
Co-Authored-By: Tom Augspurger <[email protected]>
Co-Authored-By: Tom Augspurger <[email protected]>
TomAugspurger
approved these changes
Sep 18, 2019
|
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…ly provided (pandas-dev#28417) * Updated MultiIndex.from_product to infer names * Respect None names in from_arrays
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…ly provided (pandas-dev#28417) * Updated MultiIndex.from_product to infer names * Respect None names in from_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffInfers names in
MultiIndex.from_productand normalizes handing ofnames=Nonebetweenfrom_arraysandfrom_product