Skip to content

Fix a np.random.np.random typo in "computation.rst" in document. #28400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Fix a np.random.np.random typo in "computation.rst" in document. #28400

merged 1 commit into from
Sep 12, 2019

Conversation

gepcel
Copy link
Contributor

@gepcel gepcel commented Sep 12, 2019

There's np.random.np.random in /doc/source/user_guide/computation.rst, which I believe is a typo. But the weird thing is there's actually np.random.np in numpy (1.16.4), but not in numpy (1.17.2). That's maybe why the doc build passed before. While I'm trying to build the doc locally with numpy 1.17.2, it failed.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

There's `np.random.np.random` in /doc/source/user_guide/computation.rst, which I believe is a typo. But the weird thing is there's actually `np.random.np` in numpy (1.16.4), but not in numpy (1.17.2). That's maybe why the doc build passed before. While I'm trying to build the doc locally with numpy 1.17.2, it failed.
@gfyoung gfyoung added the Docs label Sep 12, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Not clear on first look why the docs build is failing...

@jreback jreback added this to the 1.0 milestone Sep 12, 2019
@jreback jreback merged commit 6d47fab into pandas-dev:master Sep 12, 2019
@jreback
Copy link
Contributor

jreback commented Sep 12, 2019

thanks @gepcel

@gepcel gepcel deleted the patch-5 branch September 13, 2019 05:43
@jorisvandenbossche jorisvandenbossche modified the milestones: 1.0, 0.25.2 Oct 1, 2019
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport 0.25.x

@jorisvandenbossche
Copy link
Member

@meeseeksdev backport 0.25.x

@jschendel
Copy link
Member

@meeseeksdev backport to 0.25.x

@jschendel
Copy link
Member

I'll do a backport since the bot isn't responding.

jschendel pushed a commit to jschendel/pandas that referenced this pull request Oct 1, 2019
There's `np.random.np.random` in /doc/source/user_guide/computation.rst, which I believe is a typo. But the weird thing is there's actually `np.random.np` in numpy (1.16.4), but not in numpy (1.17.2). That's maybe why the doc build passed before. While I'm trying to build the doc locally with numpy 1.17.2, it failed.
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
There's `np.random.np.random` in /doc/source/user_guide/computation.rst, which I believe is a typo. But the weird thing is there's actually `np.random.np` in numpy (1.16.4), but not in numpy (1.17.2). That's maybe why the doc build passed before. While I'm trying to build the doc locally with numpy 1.17.2, it failed.
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
There's `np.random.np.random` in /doc/source/user_guide/computation.rst, which I believe is a typo. But the weird thing is there's actually `np.random.np` in numpy (1.16.4), but not in numpy (1.17.2). That's maybe why the doc build passed before. While I'm trying to build the doc locally with numpy 1.17.2, it failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants