BUG: Fix Series(List[Interval]) to infer interval dtype #28399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Bug
Dtype Conversions
jschendel
commented
Sep 12, 2019
| @@ -970,16 +970,34 @@ def test_constructor_with_naive_string_and_datetimetz_dtype(self, arg): | |||
| expected = Series(pd.Timestamp(arg)).dt.tz_localize("CET") | |||
| assert_series_equal(result, expected) | |||
|
|
|||
| def test_construction_interval(self): | |||
| @pytest.mark.parametrize("interval_constructor", [IntervalIndex, IntervalArray]) | |||
| def test_construction_interval(self, interval_constructor): | |||
There was a problem hiding this comment.
no material change here, just cleaning up by using parametrize and removing some unnecessary lines (unassigned repr/str calls)
| @pytest.mark.parametrize( | ||
| "data_constructor", [list, np.array], ids=["list", "ndarray[object]"] | ||
| ) | ||
| def test_constructor_infer_period(self, data_constructor): |
There was a problem hiding this comment.
no material change here, just cleaning up by using parametrize
mroeschke
reviewed
Sep 12, 2019
|
@jschendel can you rebase |
|
@jschendel still active? |
|
Merged master. This looks good. |
This was referenced Dec 30, 2019
jreback
requested changes
Jan 1, 2020
|
can you merge master;ping when green. |
|
#30640 needs to get merged before this will be good to go per #23563 (comment) |
|
This is green now. Anything left that I should address? |
jreback
approved these changes
Jan 6, 2020
|
lgtm. thanks @jschendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff