CLN: small ops cleanup #28379
Merged
CLN: small ops cleanup #28379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 11, 2019
| @@ -672,9 +671,6 @@ def na_op(x, y): | |||
| if is_object_dtype(x.dtype): | |||
| result = comp_method_OBJECT_ARRAY(op, x, y) | |||
|
|
|||
| elif is_datetimelike_v_numeric(x, y): | |||
There was a problem hiding this comment.
The removal here is just coupled with some of the other items you've been working on to clean up the datetimelike ops right?
There was a problem hiding this comment.
Trying to split cleanup changes off from bigger changes in preparation for a non-trivial refactor to fix arithmetic performance. This check is no longer necessary; I think it was put in place because of older numpy behavior.
WillAyd
approved these changes
Sep 11, 2019
|
thanks @jbrockmendel |
@jreback problems with ci at the moment with checks and docs, you may want to hold off merging https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=17289 |
|
thanks @simonjayhawkins |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.