BUG: Fix to_datetime(errors='coerce') not swallowing all parser exceptions...

[miggec]

… (#28299)

• closes to_datetime(foo, errors='coerce') does not swallow all errors #28299
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jreback]

cc @jbrockmendel

[jreback]

this might solve #25143, #23447, #9107

if you'd have a look (if so pls add a test for whatever this solves)

[miggec]

this might solve #25143, #23447, #9107

if you'd have a look (if so pls add a test for whatever this solves)

Looks like none of these is affected. At least one seems to be handled by a different change

[jreback]

@squigmig

Looks like none of these is affected. At least one seems to be handled by a different change

care to do a PR with a test for (which?) one

[miggec]

Looks like none of these is affected. At least one seems to be handled by a different change

care to do a PR with a test for (which?) one

sure, have raised #28386

...

Failing checks on this PR seem to be intermittent. What is the preferred way to resolve or force a re-run?

https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=17284
Checks: Setup environment and build pandas is probably the originator of the rest of the failures

Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... done

CondaHTTPError: HTTP 404 NOT FOUND for url <https://repo.anaconda.com/pkgs/main/linux-64/widgetsnbextension-3.5.1-py37_0.conda>
Elapsed: 00:00.006773
CF-RAY: 5148a6736939e0b2-IAD

An HTTP error occurred when trying to retrieve this URL.
HTTP errors are often intermittent, and a simple retry will get you on your way.

##[error]Bash exited with code '1'.
##[section]Finishing: Setup environment and build pandas```

[TomAugspurger]

Pushing an empty commit, or asking a maintainer. I've restarted the build.

…

On Wed, Sep 11, 2019 at 8:53 AM Miguel ***@***.***> wrote: Looks like none of these is affected. At least one seems to be handled by a different change care to do a PR with a test for (which?) one sure, have raised #28386 <#28386> ... Failing checks on this PR seem to be intermittent. What is the preferred way to resolve or force a re-run? https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=17284 Checks: Setup environment and build pandas is probably the originator of the rest of the failures Collecting package metadata (repodata.json): ...working... done Solving environment: ...working... done CondaHTTPError: HTTP 404 NOT FOUND for url <https://repo.anaconda.com/pkgs/main/linux-64/widgetsnbextension-3.5.1-py37_0.conda> Elapsed: 00:00.006773 CF-RAY: 5148a6736939e0b2-IAD An HTTP error occurred when trying to retrieve this URL. HTTP errors are often intermittent, and a simple retry will get you on your way. ##[error]Bash exited with code '1'. ##[section]Finishing: Setup environment and build pandas``` — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28367?email_source=notifications&email_token=AAKAOITUQ4YG3KAJNDXA5G3QJDZ7LA5CNFSM4IVFMYV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OSAPY#issuecomment-530391103>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIWV4WARTKQ7VVWZE3DQJDZ7LANCNFSM4IVFMYVQ> .

[jbrockmendel]

can the utcoffset() call raise? if not, why move this up?

[miggec]

@jbrockmendel this is an issue with the datetutil parser, see #28299 (comment)

the issue itself:
dateutil/dateutil#188

[jreback]

thanks @squigmig

[jbrockmendel]

The test this introduced is failing for me locally. Anyone else?

[TomAugspurger]

rebuild your C extensions?

…

On Thu, Sep 12, 2019 at 11:13 AM jbrockmendel ***@***.***> wrote: The test this introduced is failing for me locally. Anyone else? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28367?email_source=notifications&email_token=AAKAOIWC5FWLNP44TWXIK4LQJJTBNA5CNFSM4IVFMYV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6SNWCA#issuecomment-530897672>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKAOIVW6V7IKRW67N3YJXLQJJTBNANCNFSM4IVFMYVQ> .

[jbrockmendel]

rebuild your C extensions?

Running python3 setup.py build_ext --inplace everything looked up-to-date. Doing the same after python3 setup.py clean I'm now getting Exception: Cython-generated file 'pandas/_libs/algos.c' not found. Did the pyproject thing or something affect the workflow?

[simonjayhawkins]

yes i've got the same. on Windows. total rebuild, clean and conda env. but currently have two failures. one is the allowed failure #28125. still investigating but the failing test in pandas/tests/indexes/datetimes/test_tools.py now passes.

[jbrockmendel]

upgrading cython from 0.29.10 seems to fix the build (tentatively). i might make a PR to give a better error message for that case