CLN: catch stricter in json #28351
Merged
CLN: catch stricter in json #28351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not that I know of. Probably OK to consolidate with exception above |
WillAyd
requested changes
Sep 10, 2019
| @@ -972,10 +972,8 @@ def _try_convert_to_date(self, data): | |||
| for date_unit in date_units: | |||
| try: | |||
| new_data = to_datetime(new_data, errors="raise", unit=date_unit) | |||
| except ValueError: | |||
| except (ValueError, OverflowError): | |||
There was a problem hiding this comment.
Actually should we be catching an OutOfBoundsDatetime exception here? Not sure if test coverage is hitting that but I think easy enough to trigger (just try a date like "9999-01-01")
Out of curiosity what causes the OverflowError?
There was a problem hiding this comment.
I think it is cast_to_unit being called inside array_to_datetime, but would have to check.
OutOfBoundsDatetime subclasses ValueError so that is already caught.
|
lgtm. |
WillAyd
approved these changes
Sep 10, 2019
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WillAyd think there is a compelling reason to keep this as
breakinstead of lumping it into thecontinueclause above?(obviously the TODO comment will be removed/resolved before merge)