Skip to content

CLN: avoid bare except in tslib and tslibs.parsing #28345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

CLN: avoid bare except in tslib and tslibs.parsing #28345

merged 1 commit into from
Sep 9, 2019

Conversation

jbrockmendel
Copy link
Member

3/n

@jreback jreback added the Clean label Sep 8, 2019
@jreback jreback added this to the 1.0 milestone Sep 8, 2019
@jreback
Copy link
Contributor

jreback commented Sep 8, 2019

looks fine, but can you check the to_datetime asv's to make sure we are still performant here?

@jbrockmendel
Copy link
Member Author

with -b to_datetime it says nothing changed

@jreback jreback merged commit 5d1440e into pandas-dev:master Sep 9, 2019
@jreback
Copy link
Contributor

jreback commented Sep 9, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the raiser4 branch September 9, 2019 14:21
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: avoid bare except in tslib and tslibs.parsing (pandas-dev#28345)
2e04a87
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
CLN: avoid bare except in tslib and tslibs.parsing (pandas-dev#28345)
3bfb9db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback