CLN: catch specific Exceptions in _config #28310
Merged
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Sep 6, 2019
| @@ -100,10 +100,13 @@ def _valid_locales(locales, normalize): | |||
| def _default_locale_getter(): | |||
| try: | |||
| raw_locales = subprocess.check_output(["locale -a"], shell=True) | |||
| except subprocess.CalledProcessError as e: | |||
| raise type(e)( | |||
There was a problem hiding this comment.
apparently in the status quo this ends up raising TypeError because we are calling the CalledProcessError constructor incorrectly
There was a problem hiding this comment.
Do we even need this at all then? Seems like it wasn't doing what was expected before so maybe can remove altogether?
There was a problem hiding this comment.
I was wondering this myself. Will change.
There was a problem hiding this comment.
changed per request (and green)
|
looks fine, merge when ready (as you had a couple of questions) |
WillAyd
approved these changes
Sep 7, 2019
|
Nice job @jbrockmendel - these cleanups definitely are making things more readable |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.