BUG: datetime64 - Timestamp incorrectly raising TypeError #28286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 5, 2019
| other = ts + td | ||
|
|
||
| assert other - ts == td | ||
| assert other.to_pydatetime() - ts == td |
There was a problem hiding this comment.
Is anything above this line not tested elsewhere? Just was a little counter intuitive to read as I thought this PR was only about datetime64 obects
There was a problem hiding this comment.
trying to follow the pattern in these tests of testing all datetime-like scalars in the same place
WillAyd
reviewed
Sep 5, 2019
| other = ts + td | ||
|
|
||
| assert other - ts == td | ||
| assert other.to_pydatetime() - ts == td |
|
|
||
| assert other - ts == td | ||
| assert other.to_pydatetime() - ts == td | ||
| if tz_naive_fixture is None: |
There was a problem hiding this comment.
What should happen if this is not None? Should there be a test for this?
There was a problem hiding this comment.
should raise bc of tzawareness compat, will update test to include that
|
Travis has been done for a few hours, no idea why it’s stuck on yellow |
|
lgtm. can you rebase and push again. |
|
rebased+green |
WillAyd
approved these changes
Sep 7, 2019
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff