BUG: Make sure correct values are passed to Rolling._on when axis=1 #28267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 3, 2019
pandas/core/window/rolling.py
Outdated
| if self.axis == 0: | ||
| return self.obj.index | ||
| elif self.axis == 1: | ||
| return self.obj.transpose().index |
There was a problem hiding this comment.
I think we can just call self.obj.columns instead of having to transpose.
MarcoGorelli
changed the title
added 2 commits
September 4, 2019 09:59
|
lgtm. @mroeschke think we need more testing for this? |
mroeschke
reviewed
Sep 4, 2019
pandas/tests/window/test_rolling.py
Outdated
| @@ -334,3 +334,26 @@ def test_readonly_array(self): | |||
| result = pd.Series(arr).rolling(2).mean() | |||
| expected = pd.Series([np.nan, 2, np.nan, np.nan, 4]) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_rolling_datetime(self, axis_frame): | |||
There was a problem hiding this comment.
One last thing: Could you parameterize over the tz_naive_fixture?
|
Hello @MarcoGorelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-09-04 16:32:05 UTC |
added 2 commits
September 4, 2019 17:31
|
Thanks @MarcoGorelli! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…andas-dev#28267) * Make sure correct values are passed to Rolling._on when axis=1 * Update rolling.py * Capitalise 'd' as in documentation * Parametrize over tz_naive_fixture * autoformat
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…andas-dev#28267) * Make sure correct values are passed to Rolling._on when axis=1 * Update rolling.py * Capitalise 'd' as in documentation * Parametrize over tz_naive_fixture * autoformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff