BUG: fix custom xticks in bar() plotting function #28172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks! Can you add the example from #14119 as a test in pandas/tests/plotting/test_series.py` and make an assertion that the output x tick labels match the expected?
pandas/plotting/_matplotlib/core.py
Outdated
| ax.set_xticks(self.tick_pos) | ||
| ax.set_xticklabels(ticklabels) | ||
|
|
||
| if self.custom_tick_pos is not None: |
There was a problem hiding this comment.
So, here is where we'd want to see if self.xticks works with your changes.
Co-Authored-By: Tom Augspurger <[email protected]>
TomAugspurger
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
This looks good, pending the discussion in #28172 (comment)
|
@GiuPassarelli can you merge master and fix conflict? I think just one outstanding comment here otherwise right? |
TomAugspurger
approved these changes
Sep 13, 2019
|
Thanks @GiuPassarelli! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff