DOC: Fix RangeIndex and other docstrings for missing period in summary #28123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
August 21, 2019 06:02
pandas/core/indexes/range.py
Outdated
| """ | ||
| # GH 25710 | ||
| return self._range.start | ||
|
|
||
| @property | ||
| def _start(self): | ||
| """ | ||
| The value of the `start` parameter (``0`` if this was not supplied) | ||
| The value of the `start` parameter.(``0`` if this was not supplied) |
pandas/core/indexes/range.py
Outdated
| @@ -282,15 +282,15 @@ def _stop(self): | |||
| @cache_readonly | |||
| def step(self): | |||
| """ | |||
| The value of the `step` parameter (``1`` if this was not supplied) | |||
| The value of the `step` parameter.(``1`` if this was not supplied) | |||
pandas/core/indexes/range.py
Outdated
| """ | ||
| # GH 25710 | ||
| return self._range.step | ||
|
|
||
| @property | ||
| def _step(self): | ||
| """ | ||
| The value of the `step` parameter (``1`` if this was not supplied) | ||
| The value of the `step` parameter.(``1`` if this was not supplied) |
added 5 commits
August 24, 2019 06:58
|
@datapythonista - have made the requested changes. Thanks |
bhuvanakundumani
changed the title
pandas/core/indexes/numeric.py
Outdated
| @@ -168,7 +168,7 @@ def _union(self, other, sort): | |||
| ] = """ | |||
| Immutable ndarray implementing an ordered, sliceable set. The basic object | |||
| storing axis labels for all pandas objects. %(klass)s is a special case | |||
| of `Index` with purely %(ltype)s labels. %(extra)s | |||
| of `Index` with purely %(ltype)s labels. | |||
There was a problem hiding this comment.
Can you revert this one for now. It's a bit more complex, we'll take care of it in a separate PR.
pandas/core/indexes/range.py
Outdated
| """ | ||
| # GH 25710 | ||
| return self._range.step | ||
|
|
||
| @property | ||
| def _step(self): | ||
| """ | ||
| The value of the `step` parameter (``1`` if this was not supplied) | ||
| The value of the `step` parameter(``1`` if this was not supplied). |
pandas/core/reshape/merge.py
Outdated
| @@ -177,8 +177,8 @@ def merge_ordered( | |||
| ): | |||
| """ | |||
| Perform merge with optional filling/interpolation designed for ordered | |||
| data like time series data. Optionally perform group-wise merge (see | |||
| examples) | |||
| data like time series data. Optionally perform group-wise merge(see | |||
datapythonista
approved these changes
Aug 24, 2019
There was a problem hiding this comment.
Looks perfect now, thanks a lot for the fixes @bhuvanakundumani.
|
Thanks @bhuvanakundumani |
|
Thanks @datapythonista @WillAyd. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@datapythonista
I added the period to the following cases:
pandas.Categorical.dtype: Summary does not end with a period
pandas.merge_ordered: Summary does not end with a period
pandas.bdate_range: Summary does not end with a period
pandas.period_range: Summary does not end with a period
pandas.timedelta_range: Summary does not end with a period
pandas.interval_range: Summary does not end with a period
pandas.util.hash_pandas_object: Summary does not end with a period
pandas.Grouper: Summary does not end with a period
pandas.Index.memory_usage: Summary does not end with a period
pandas.Index.fillna: Summary does not end with a period
pandas.Index.dropna: Summary does not end with a period
pandas.RangeIndex.start: Summary does not end with a period
pandas.RangeIndex.stop: Summary does not end with a period
pandas.RangeIndex.step: Summary does not end with a period