DOC: Fixes to docstrings formatting #28096
Conversation
…ead_csv function, for issue 27655.
…ready determined automatically if left empty.
… some of pandas.ExcelFile.parse (issue pandas-dev#27979)
…pied-over summary from its parent DateOffset
|
Hello @realjohnward! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-24 15:09:22 UTC |
|
@datapythonista Here is the new PR I said I'd make in the PR you requested changes on. |
|
How do I resolve the failed checks? @datapythonista |
| @@ -431,8 +431,9 @@ def _is_metadata_of(group, parent_group): | |||
| class HDFStore: | |||
|
|
|||
There was a problem hiding this comment.
can you remove this extra newline
There was a problem hiding this comment.
looks great, thanks for the fixes @realjohnward
I added couple of comments, but also check the logs of the CI to see what's exactly complaining about
pandas/tseries/offsets.py
Outdated
| @@ -231,18 +230,25 @@ def __add__(date): | |||
| - microsecond | |||
| - nanosecond | |||
|
|
|||
| . | |||
|
|
|||
pandas/tseries/offsets.py
Outdated
|
|
||
| to be applied to an existing datetime an can replace specific components of | ||
|
|
||
| that datetime, or represents an interval of time. |
There was a problem hiding this comment.
to continue with the description of the see also, avoid the blank lines and indent the continued description
There was a problem hiding this comment.
Thank you for getting back to me, just committed the changes you requested.
There was a problem hiding this comment.
Looks good, nice PR @realjohnward, thanks for working on this.
Feel free to keep working on those errors, we have as much as you can want to fix. :)
|
Thanks @realjohnward |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff