Skip to content

DOC: Add punctuation to IntervalArray docstrings #28043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2019
Merged

DOC: Add punctuation to IntervalArray docstrings #28043

merged 1 commit into from
Aug 21, 2019

Conversation

sparalic
Copy link
Contributor

@sparalic sparalic commented Aug 20, 2019 •
edited
Loading

Added missing period to IntervalArray docstrings as suggested by @datapythonista for the following attributes and parameters:

pandas.arrays.IntervalArray.left
pandas.arrays.IntervalArray.right
pandas.arrays.IntervalArray.closed
pandas.arrays.IntervalArray.mid
pandas.arrays.IntervalArray.length
pandas.arrays.IntervalArray.is_non_overlapping_monotonic
pandas.arrays.IntervalArray.from_tuples
pandas.arrays.IntervalArray.set_closed
pandas.arrays.IntervalArray.to_tuples

@sparalic sparalic changed the title Add punctuation to IntervalArray docstrings DOC:Add punctuation to IntervalArray docstrings Aug 20, 2019
datapythonista
datapythonista approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sparalic

@sparalic sparalic mentioned this pull request Aug 21, 2019
Merged
5 tasks
@sparalic
Copy link
Contributor Author

This was my fault. I did not switch branches. Let me know if I need to fix this again.

@jorisvandenbossche jorisvandenbossche changed the title DOC:Add punctuation to IntervalArray docstrings DOC: Add punctuation to IntervalArray docstrings Aug 21, 2019
jorisvandenbossche
jorisvandenbossche approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche
Copy link
Member

(failure is unrelated)

@jorisvandenbossche jorisvandenbossche merged commit b7aacb1 into pandas-dev:master Aug 21, 2019
@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Aug 21, 2019
galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
@sparalic @galuhsahid
DOC: Add punctuation to IntervalArray docstrings (pandas-dev#28043)
261b83d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sparalic @jorisvandenbossche @datapythonista