-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Avoid duplicating entire exploded column when joining back with origi… #28010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Avoid duplicating entire exploded column when joining back with origi… #28010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment for performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments
cd95131
to
44fb064
Compare
Hello @MarcoGorelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-09-15 23:06:12 UTC |
ccb4419
to
e4303bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one final suggestion
0f75eb3
to
f8ce5e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two last small things, and from my side looks good. Thanks for the patience on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @MarcoGorelli
Thanks for your help Marc, really appreciate it! |
Syntax: python explode.py infile template [range] The template argument is used to construct the names of the individual frame files. The frames are numbered file001.ext, file002.ext, etc. You can insert %d to control the placement and syntax of the frame number. The optional range argument specifies which frames to extract. You can give one or more ranges like 1-10, 5, -15 etc. If omitted, all frames are extracted. method of frame so it doesn't require exploding a series twice
@MarcoGorelli looks like a git merge issue. Can you try fetching and merging master, and then repushing? Let us know if you get stuck. |
c006d4b
to
96cfb08
Compare
3ab3338
to
71a12fe
Compare
@TomAugspurger sorry to chase you up on this - I've resolved the merge conflict, is there anything else you'd like changed? |
Thanks! |
…nal frame
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff