Skip to content

BUG: Avoid duplicating entire exploded column when joining back with origi… #28010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Sep 17, 2019

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Aug 19, 2019

…nal frame

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment for performance.

@datapythonista datapythonista added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode API Design labels Aug 19, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments

@pep8speaks
Copy link

pep8speaks commented Aug 20, 2019

Hello @MarcoGorelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-15 23:06:12 UTC

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one final suggestion

@MarcoGorelli MarcoGorelli force-pushed the exploding-frames branch 2 times, most recently from 0f75eb3 to f8ce5e3 Compare August 29, 2019 15:30
@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 29, 2019
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two last small things, and from my side looks good. Thanks for the patience on this.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @MarcoGorelli

@MarcoGorelli
Copy link
Member Author

Thanks for your help Marc, really appreciate it!

Marco Gorelli added 9 commits September 3, 2019 08:18
Syntax: python explode.py infile template [range]

The template argument is used to construct the names of the
individual frame files.  The frames are numbered file001.ext,
file002.ext, etc.  You can insert %d to control the placement
and syntax of the frame number.

The optional range argument specifies which frames to extract.
You can give one or more ranges like 1-10, 5, -15 etc.  If
omitted, all frames are extracted. method of frame so it doesn't require exploding a series twice
@TomAugspurger
Copy link
Contributor

@MarcoGorelli looks like a git merge issue. Can you try fetching and merging master, and then repushing? Let us know if you get stuck.

@MarcoGorelli MarcoGorelli changed the title Avoid duplicating entire exploded column when joining back with origi… BUG: Avoid duplicating entire exploded column when joining back with origi… Sep 3, 2019
@MarcoGorelli
Copy link
Member Author

@TomAugspurger sorry to chase you up on this - I've resolved the merge conflict, is there anything else you'd like changed?

@TomAugspurger TomAugspurger merged commit 372a9a0 into pandas-dev:master Sep 17, 2019
@TomAugspurger
Copy link
Contributor

Thanks!

@MarcoGorelli MarcoGorelli deleted the exploding-frames branch September 17, 2019 13:43
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explode on identical index causes duplication
5 participants