BUG: Avoid duplicating entire exploded column when joining back with origi… #28010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Aug 19, 2019
datapythonista
requested changes
Aug 19, 2019
datapythonista
added
Bug
Reshaping
MarcoGorelli
force-pushed
the
exploding-frames
branch
from
cd95131 to
44fb064
Compare
|
Hello @MarcoGorelli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-09-15 23:06:12 UTC |
MarcoGorelli
force-pushed
the
exploding-frames
branch
from
ccb4419 to
e4303bd
Compare
MarcoGorelli
force-pushed
the
exploding-frames
branch
2 times, most recently
from
0f75eb3 to
f8ce5e3
Compare
datapythonista
approved these changes
Aug 30, 2019
|
Thanks for your help Marc, really appreciate it! |
jreback
requested changes
Aug 30, 2019
jreback
requested changes
Sep 2, 2019
added 9 commits
September 3, 2019 08:18
Syntax: python explode.py infile template [range] The template argument is used to construct the names of the individual frame files. The frames are numbered file001.ext, file002.ext, etc. You can insert %d to control the placement and syntax of the frame number. The optional range argument specifies which frames to extract. You can give one or more ranges like 1-10, 5, -15 etc. If omitted, all frames are extracted. method of frame so it doesn't require exploding a series twice
|
@MarcoGorelli looks like a git merge issue. Can you try fetching and merging master, and then repushing? Let us know if you get stuck. |
MarcoGorelli
force-pushed
the
exploding-frames
branch
from
c006d4b to
96cfb08
Compare
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
exploding-frames
branch
from
3ab3338 to
71a12fe
Compare
|
@TomAugspurger sorry to chase you up on this - I've resolved the merge conflict, is there anything else you'd like changed? |
|
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nal frame
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff