Skip to content

DOC: Corrected file description in read_fwf() #28009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2019
Merged

DOC: Corrected file description in read_fwf() #28009

merged 4 commits into from
Aug 20, 2019

Conversation

isantolin
Copy link
Contributor

@isantolin isantolin commented Aug 19, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@datapythonista
Copy link
Member

Changing the name looks good, but can you please remove the link to Oracle? That document is not a spec or description of the format, it's a description of how to open fixed width files with Oracle Enterprise Data Quality, and I don't think we want to have that. It's ok to have no link if there is no good page to link to.

Thanks!

@datapythonista datapythonista added Docs IO CSV read_csv, to_csv labels Aug 19, 2019
@isantolin
Copy link
Contributor Author

@datapythonista Link removed. Can you merge?

@TomAugspurger
Copy link
Contributor

Needs to pass CI first.

@@ -28,7 +28,7 @@ The pandas I/O API is a set of top level ``reader`` functions accessed like
:delim: ;

text;`CSV <https://en.wikipedia.org/wiki/Comma-separated_values>`__;:ref:`read_csv<io.read_csv_table>`;:ref:`to_csv<io.store_in_csv>`
text;`TXT <https://www.oracle.com/webfolder/technetwork/data-quality/edqhelp/Content/introduction/getting_started/configuring_fixed_width_text_file_formats.htm>`__;:ref:`read_fwf<io.fwf_reader>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have like an empty list now, the backticks and underscores are not needed. After fixing that, can you also render the documentation and post a screenshot to see that it looks like expected please?

@isantolin
Copy link
Contributor Author

@TomAugspurger , @datapythonista CI Tests passed, please merge!

@datapythonista
Copy link
Member

@isantolin would be really appreciated if you could stop telling us when to merge. Thanks

@TomAugspurger TomAugspurger merged commit 8110b47 into pandas-dev:master Aug 20, 2019
@TomAugspurger TomAugspurger added this to the 1.0 milestone Aug 20, 2019
galuhsahid pushed a commit to galuhsahid/pandas that referenced this pull request Aug 25, 2019
* DOC: Corrected file description in read_fwf()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants